Re: [PATCH] conf: fix use after free in virChrdevOpen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/22/2013 05:37 AM, Ján Tomko wrote:
> Don't free the stream on error if we've successfully added it
> to the hash table, since it will be freed by virChrdevHashEntryFree
> callback.
> 
> Preserve the error message before calling virStreamFree, since it
> resets the error.
> 
> Reported by Sergey Fionov on libvir-list.
> ---
>  src/conf/virchrdev.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)

ACK.  It might help if you track down which commit introduced the
problem and mention that in the commit message.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]