On 12/05/2012 09:29 AM, Michal Privoznik wrote: >> + * >> + * Since 1.0.1 VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA >> + * in flags can be used to get higher performance with >> + * qcow2 image files which don't support full preallocation, >> + * by creating a sparse image file with metadata. > > The 'Since 1.0.1' is not needed as users can simply 'git blame > include/libvirt/libvirt.h.in'. Moreover, we are not using it anywhere > among code. I'd reword this as 'The VIR_STORAGE_..._METADATA flag can be > used to ...'. Someday, it would be really nice to expand http://libvirt.org/hvsupport.html to say which flags are supported since which version (that is, knowing that virDomainStartFlags() is available is interesting, but it is even more interesting to know _which_ drivers support which flags, and when support for those flags was added). But if we ever do come up with a way to list per-flag support for APIs, I think automating it to the hvsupport.html page is sufficient; we don't also need to call it out in the libvirt.c documentation. So I'm okay with the complaint of not needing the 'since 1.0.1' here. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list