> This resolves: > > https://bugzilla.redhat.com/show_bug.cgi?id=881480 > > These three functions: > > virDomainNetGetActualBridgeName > virDomainNetGetActualDirectDev > virDomainNetGetActualDirectMode > > return attributes that are in a union whose contents are interpreted > differently depending on the actual->type and so they should only > return non-0 when actual->type is 'bridge' (in the first case) or > 'direct' (in the other two cases, but I had neglected to do that, > (The other two functions weren't causing any behavioral problems in > virDomainChangeNet(), but their problem and fix was identical, so I > included them in this same patch). > > were supposed to only return non-0 values when Spurious line in the commit message. > --- > src/conf/domain_conf.c | 33 ++++++++++++++++++--------------- > 1 file changed, 18 insertions(+), 15 deletions(-) ACK. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list