On 26.11.2012 11:34, Daniel P. Berrange wrote: > On Sun, Nov 25, 2012 at 02:59:33AM +0100, Ján Tomko wrote: >> Commit 258e06c removed setting of the volume type to >> VIR_STORAGE_VOL_BLOCK, which leads to failures in >> storageVolumeCreateXMLFrom. >> >> The type (and target.format) of the volume was set to zero. In >> virStorageBackendGetBuildVolFromFunction, this gets interpreted as >> VIR_STORAGE_FILE_NONE and the qemu-img tool is called with unknown >> "none" format. >> >> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=879780 >> --- >> src/storage/storage_backend_logical.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c >> index de43c3a..fd5cbd1 100644 >> --- a/src/storage/storage_backend_logical.c >> +++ b/src/storage/storage_backend_logical.c >> @@ -708,6 +708,8 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn, >> return -1; >> } >> >> + vol->type = VIR_STORAGE_VOL_BLOCK; >> + >> if (vol->target.path != NULL) { >> /* A target path passed to CreateVol has no meaning */ >> VIR_FREE(vol->target.path); > > ACK > > Daniel > Pushed now. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list