Re: [PATCH v3 UPDATED 1/2] Qemu/Gluster: Add Gluster protocol as supported network disk formats.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/22/2012 01:49 AM, Harsh Bora wrote:

>>> +        transp = strstr(uri->scheme, "+");

strstr() for a single-byte needle is overkill.

>>> +        transp++;
>>
>> You could even squash the increment into the previous line :-)
> 
> That would give me:
> 
> qemu/qemu_command.c: In function 'qemuParseGlusterString':
> qemu/qemu_command.c:2048:18: error: lvalue required as left operand of
> assignment.

Not if you do:

transp = strchr(uri->scheme, '+') + 1;

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]