Re: [PATCH] Use virNetServerRun instead of custom main loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/21/2012 06:05 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> The LXC controller code currently directly invokes the
> libvirt main loop code. The problem is that this misses
> the cleanup of virNetServerClient connections that
> virNetServerRun takes care of.
> 
> The result is that when libvirtd is stopped, the
> libvirt_lxc controller process gets stuck in a I/O loop.
> When libvirtd is then started again, it fails to connect
> to the controller and thus kills of the entire domain.

s/of/off/

> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/lxc/lxc_controller.c | 33 ++++++++++++++-------------------
>  1 file changed, 14 insertions(+), 19 deletions(-)

ACK.  Always nice when using the right API to fix a bug also makes the
code smaller.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]