v1 was here: https://www.redhat.com/archives/libvir-list/2012-November/msg00484.html Since then, I've folded in review comments on 1; 2-4 are new. Documentation is still pending (split out of 1 based on the v1 review). Also, I'm still writing and testing the actual qemu use of the new snapshot_conf.c code, so this series is not quite ready for committing without that being done. In my review of Peter's series, I promised to post my patch for making it easier to clone the in-memory view of a domain when creating or reverting to a snapshot; that's patch 3. Eric Blake (4): snapshot: add revert-and-create branching of external snapshots snapshot: prepare to parse new XML snapshot: make cloning of domain definition easier snapshot: actually compute branch definition from XML docs/formatsnapshot.html.in | 16 +++++-- docs/schemas/domainsnapshot.rng | 5 +++ include/libvirt/libvirt.h.in | 3 ++ src/conf/domain_conf.c | 37 ++++++++++------ src/conf/domain_conf.h | 2 + src/conf/snapshot_conf.c | 93 ++++++++++++++++++++++++++++++++++++++- src/conf/snapshot_conf.h | 2 + src/esx/esx_driver.c | 2 +- src/libvirt.c | 27 +++++++++--- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 17 ++----- src/vbox/vbox_tmpl.c | 2 +- tests/domainsnapshotxml2xmltest.c | 2 +- tools/virsh-snapshot.c | 40 +++++++++++++---- tools/virsh.pod | 16 ++++++- 15 files changed, 215 insertions(+), 50 deletions(-) -- 1.7.11.7 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list