On Fri, Nov 16, 2012 at 12:51:46PM +0800, Osier Yang wrote: > On 2012年11月16日 11:27, liguang wrote: > >Signed-off-by: liguang<lig.fnst@xxxxxxxxxxxxxx> > >--- > > src/qemu/qemu_migration.c | 18 ++++++------------ > > 1 files changed, 6 insertions(+), 12 deletions(-) > > > >diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c > >index 716365f..0e00cac 100644 > >--- a/src/qemu/qemu_migration.c > >+++ b/src/qemu/qemu_migration.c > >@@ -692,12 +692,10 @@ qemuMigrationCookieXMLFormat(struct qemud_driver *driver, > > qemuMigrationCookieFlagTypeToString(i)); > > } > > > >- if ((mig->flags& QEMU_MIGRATION_COOKIE_GRAPHICS)&& > >- mig->graphics) > >+ if ((mig->flags& QEMU_MIGRATION_COOKIE_GRAPHICS)&& mig->graphics) > > qemuMigrationCookieGraphicsXMLFormat(buf, mig->graphics); > > Things like this is really personal favor I think. I say if it is not over 80 chars, then keeping it all on one line is nice. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list