On Tue, Nov 13, 2012 at 07:22:35PM +0100, Zeeshan Ali (Khattak) wrote:
> On Tue, Nov 13, 2012 at 7:10 PM, Alexander Larsson <alexl@xxxxxxxxxx> wrote:
> > This is a wrapper for virDomainUpdateDeviceFlags.
>
> Looks good. ACK.
>
> > diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym
> > index 3a40a8a..2034e89 100644
> > --- a/libvirt-gobject/libvirt-gobject.sym
> > +++ b/libvirt-gobject/libvirt-gobject.sym
> > @@ -204,4 +204,11 @@ LIBVIRT_GOBJECT_0.1.3 {
> > gvir_domain_wakeup_finish;
> > } LIBVIRT_GOBJECT_0.1.2;
> >
> > +LIBVIRT_GOBJECT_0.1.4 {
> > + global:
> > + gvir_domain_update_device_flags_get_type;
> > + gvir_domain_update_device;
> > +} LIBVIRT_GOBJECT_0.1.3;
>
> I guess you need to rebase this on current git master?
This looks good with respect to current git master, this part will indeed
conflict with some of the patches that are up for review on the mailing
list, maybe you have some of those applied?
Christophe
Attachment:
pgpXX6QF8m5HC.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list