在 2012-11-08四的 21:50 -0700，Eric Blake写道： > On 11/08/2012 09:31 PM, li guang wrote: > >>> seem flags was forgotten at qemuDomainMigratePrepare3, so any > >>> preparation for offline migration will be impossible, isn't it? > >>> do you mean I should change MigratePrepare functions to add > >>> flags as a parameter? > >> > >> Huh? qemuDomainMigratePrepare3 already has a flags argument (arg 8), > >> and it is directly related to the flags argument that was originally > >> passed to virDomainMigrate() in libvirt.c. > >> > > > > please check qemuMigrationPrepareDirect called in > > qemuDomainMigratePrepare3 > > qemuMigrationPrepareDirect is not a callback, and not a public API, so > you are free to change its signature and add a flags parameter if that > is necessary to get the information to the right places. The only > signatures you can't change are in src/libvirt.c and in functions > serving as callbacks registered through signatures in src/driver.h. > OK, will change. -- li guang lig.fnst@xxxxxxxxxxxxxx linux kernel team at FNST, china -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list