Re: [PATCH] Check for private symbols presence as well

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05.10.2012 15:13, Eric Blake wrote:
> On 10/05/2012 07:05 AM, Michal Privoznik wrote:
>> Currently, we are checking if libvirt.so contains public symbols.
>> However, sometimes we rename an internal symbol and forget to
>> change libvirt_private.syms accordingly. Hence, it's safer to check
>> for internal symbols as well.
>> ---
>>  src/Makefile.am      |    7 ++++++-
>>  src/check-symfile.pl |    2 +-
>>  2 files changed, 7 insertions(+), 2 deletions(-)
>>
> 
> ACK.  I confirmed that this catches the problem fixed by your commit
> fcd6477.
> 
> 

Thanks, pushed.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]