On Tue, Sep 25, 2012 at 10:11 AM, Eric Blake <eblake@xxxxxxxxxx> wrote: > On 09/25/2012 03:30 AM, Martin Kletzander wrote: >> On 09/25/2012 11:23 AM, Jiri Denemark wrote: >>> On Tue, Sep 25, 2012 at 11:16:32 +0200, Martin Kletzander wrote: >>>> On 09/25/2012 09:38 AM, Jiri Denemark wrote: >>>>> On Mon, Sep 24, 2012 at 18:44:34 -0500, Doug Goldstein wrote: >>>>>> --enable-compile-warnings=error has been renamed to --enable-werror so >>>>>> update the HACKING and the hacking.html to reflect that. >>>>>> --- >>>>>> docs/hacking.html.in | 2 +- >>>>>> 1 files changed, 1 insertions(+), 1 deletions(-) > >>>>> ACK >>>>> >>>>> Jirka >>>>> >>>> >>>> Don't forget to change it in the HACKING as well ;) >>> >>> That file is autogenerated from hacking.html.in ;) > > Yes, but only after 'make', and since it is one of the few > version-controlled generated files, it DOES need to be touched as part > of this commit, so that fresh checkouts aren't dirty. > > Given Dan's reminder, I'm squashing this in, regenerating HACKING, and > pushing the patch. > > diff --git i/docs/hacking.html.in w/docs/hacking.html.in > index c3f859c..9de5eb1 100644 > --- i/docs/hacking.html.in > +++ w/docs/hacking.html.in > @@ -74,7 +74,9 @@ > <li>Make sure your patches apply against libvirt GIT. Developers > only follow GIT and don't care much about released versions.</li> > <li><p>Run the automated tests on your code before submitting any > changes. > - In particular, configure with compile warnings set to > -Werror:</p> > + In particular, configure with compile warnings set to > + -Werror. This is done automatically for a git checkout; from a > + tarball, use:</p> > <pre> > ./configure --enable-werror > </pre> > > > -- Ah. And I actually pulled it out of the commit before sending it along because I saw it was autogenerated. But your rationale makes sense. Thanks guys. -- Doug Goldstein -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list