Re: [PATCH v2 1/9] fix bug in qemuSetupCgroupForEmulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/06/2012 10:56 PM, Eric Blake wrote:
> On 09/06/2012 04:13 AM, Hu Tao wrote:
>> Should not return 0 when failed to setup cgroup.
>> ---
>>  src/qemu/qemu_cgroup.c |    8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> ACK with one nit.
> 

>> +        if (rc < 0)
>>          goto cleanup;
> 
> Indentation is now off.

Pushed with this fixed.  Awaiting v3 for the rest of the series, but do
make sure that you are aware of the interface that Dan has proposed and
reconcile according to my suggestions:
https://www.redhat.com/archives/libvir-list/2012-September/msg00698.html

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]