On 09/06/2012 04:13 AM, Hu Tao wrote:
> Should not return 0 when failed to setup cgroup.
> ---
> src/qemu/qemu_cgroup.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
ACK with one nit.
>
> diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
> index 5b42793..c95cc77 100644
> --- a/src/qemu/qemu_cgroup.c
> +++ b/src/qemu/qemu_cgroup.c
> @@ -691,13 +691,15 @@ int qemuSetupCgroupForEmulator(struct qemud_driver *driver,
> }
>
> if (def->cputune.emulatorpin &&
> - qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_CPUSET) &&
> - qemuSetupCgroupEmulatorPin(cgroup_emulator, def->cputune.emulatorpin) < 0)
> + qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_CPUSET)) {
> + rc = qemuSetupCgroupEmulatorPin(cgroup_emulator, def->cputune.emulatorpin);
> + if (rc < 0)
> goto cleanup;
Indentation is now off.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list