Re: [Qemu-devel] [PATCH v7 2/6] qapi: Introduce add-fd, remove-fd, query-fdsets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 08/08/2012 04:48 PM, Luiz Capitulino wrote:
On Wed, 08 Aug 2012 15:07:02 -0400
Corey Bryant <coreyb@xxxxxxxxxxxxxxxxxx> wrote:



On 08/07/2012 06:16 PM, Eric Blake wrote:
On 08/07/2012 11:07 AM, Corey Bryant wrote:

+#
+# Since: 1.2.0

We're not very consistent on '1.2' vs. '1.2.0' in since listings, but
that's probably worth a global cleanup closer to hard freeze.


I'll make a note of it.  Or does Luiz usually do a cleanup?

No idea.


Luiz, were you planning to take a pass at cleaning up the "since"
release?  If not let me know and I can submit a patch.  Just let me know
which to use, '1.2' or '1.2.0'.

I'd appreciate it if you submit a patch. I guess we should use 1.2.0.


Sure I'll do that.

Btw, should I be using error_set(errp, ERROR_CLASS_GENERIC_ERROR, "...") and have a dependency on your patch series? Or should I stick with the old error messages?

--
Regards,
Corey

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]