On 04/10/2012 08:03 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > * src/qemu/qemu_command.c: Wire up -bios with <loader> > * tests/qemuxml2argvdata/qemuxml2argv-bios.args, > tests/qemuxml2argvdata/qemuxml2argv-bios.xml: Expand > existing BIOS test case to cover <loader> > --- > src/qemu/qemu_command.c | 9 +++++++++ > tests/qemuxml2argvdata/qemuxml2argv-bios.args | 3 ++- > tests/qemuxml2argvdata/qemuxml2argv-bios.xml | 1 + > 3 files changed, 12 insertions(+), 1 deletions(-) > I just realized (thanks to https://bugzilla.redhat.com/show_bug.cgi?id=836145) that we never documented how to use <loader> to influence whether a guest will be started with a BIOS that advertises or suppresses S3 support (since there are definitely guests that do not work if S3 is advertised). We need a followup patch to formatdomain.html.in, since it currently claims that the <loader> sublement is only useful for Xen. > +++ b/src/qemu/qemu_command.c > @@ -4052,6 +4052,11 @@ qemuBuildCommandLine(virConnectPtr conn, > if (enableKVM) > virCommandAddArg(cmd, "-enable-kvm"); > > + if (def->os.loader) { > + virCommandAddArg(cmd, "-bios"); > + virCommandAddArg(cmd, def->os.loader); > + } > + > /* Set '-m MB' based on maxmem, because the lower 'memory' limit > * is set post-startup using the balloon driver. If balloon driver > * is not supported, then they're out of luck anyway. Update the -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list