Re: [PATCH] Wire up <loader> to set the QEMU BIOS path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/10/2012 08:03 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> * src/qemu/qemu_command.c: Wire up -bios with <loader>
> * tests/qemuxml2argvdata/qemuxml2argv-bios.args,
>   tests/qemuxml2argvdata/qemuxml2argv-bios.xml: Expand
>   existing BIOS test case to cover <loader>
> ---
>  src/qemu/qemu_command.c                       |    9 +++++++++
>  tests/qemuxml2argvdata/qemuxml2argv-bios.args |    3 ++-
>  tests/qemuxml2argvdata/qemuxml2argv-bios.xml  |    1 +
>  3 files changed, 12 insertions(+), 1 deletions(-)

Best part is it's already documented XML, so I'm okay with no extra docs.

ACK.

>  
> +    if (def->os.loader) {
> +        virCommandAddArg(cmd, "-bios");
> +        virCommandAddArg(cmd, def->os.loader);
> +    }

You could have done this in fewer lines:

if (def->os.loader)
    virCommandAddArgList(cmd, "-bios", def->os.loader, NULL);

but not worth changing if you don't want to.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]