On Mon, Jun 25, 2012 at 06:54:12PM +0200, Viktor Mihajlovski wrote: > On 06/25/2012 04:43 PM, Michal Privoznik wrote: > >On 25.06.2012 15:54, Daniel Veillard wrote: > >>On Mon, Jun 25, 2012 at 09:43:41PM +0800, Daniel Veillard wrote: [...] > >>>>thanks for reviewing the patches, we will send out a cleaned up > >>>>version shortly. > >>> > >>> Well I reviewed only 2 of the set, lemme try to get a bit further :-) > >> > >> Actually now that I went though all 5 and since Dan Berrange reviewed > >>them too, it seems to me this code should not generate portability > >>troubles for other platforms (which was my main concern at this point). > >>So I would agree with trying to push that patch set in rc2 if you fix > >>the few issues which were raised, and send the new set within a couple > >>of days. > >> > >> Thanks ! > >> > >>Daniel > >> > > > >Well, I went ahead and cleaned up some nits you guys pointed our or I've > >spotted myself. Viktor, can you please give it a try and send any follow > >up patch if you find anything not working? Thanks Michal ! > Hi Michal, > > thanks for fixing the issues :-). I rebased my local branch to > upstream and everything is working as expected. > Please note that my other patch set (virtio support for s390) is > needed to start s390 guests with I/O devices. As this touches common > areas in the qemu driver, I'll hold off until 0.9.13 is out of the > door. Right, that set will have to wait for next week :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list