On 04/19/2012 10:25 AM, Osier Yang wrote:
--- utils/dev_num.sh | 2 +- utils/disk_num.sh | 2 +- utils/ipget.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/dev_num.sh b/utils/dev_num.sh index 5e79313..552721b 100755 --- a/utils/dev_num.sh +++ b/utils/dev_num.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash # counting disk and interface numbers guestname=$1 diff --git a/utils/disk_num.sh b/utils/disk_num.sh index 8c10e52..57f46aa 100755 --- a/utils/disk_num.sh +++ b/utils/disk_num.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash guestname=$1 if [[ -z $guestname ]]; then diff --git a/utils/ipget.sh b/utils/ipget.sh index 8d44b14..dd074be 100755 --- a/utils/ipget.sh +++ b/utils/ipget.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/bash mac=$1 if [[ -z $mac ]]; then
I don't think it's right. The /bin/sh is symbolic link to bash in most GNU/Linux. But it could be a link to another shell (ksh, dash) we should make the script more portable to support POSIX shell. NACK Guannan Ren -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list