The TODO in round 2 is still not done, but let's get these cleanups reviewed first. Osier Yang (14): Change libvirt-test-api to be executable Remove NEWS and TODO Destroy utils/check.py and move the functions into utils/utils.py Move directory dist to src Move utils/env_parser.py into src Improve the comments telling what the scripts does for utils/*.py Improve more comments to tell what the program does Remove trainling blank lines for utils/*.sh Use bash as the interpreter explicitly Substitute 'guesttype' with 'virt_type' Update AUTHORS Rename utils/*.py with consistent naming style Rename src/logxmlparser.py as src/log_generator.py Rename 'env.cfg' as 'global.cfg' AUTHORS | 17 +- TODO | 4 - cases/consumption_cpu_topology.conf | 2 +- cases/consumption_domain_nfs_start.conf | 2 +- cases/consumption_eventhandler.conf | 2 +- cases/consumption_libvirtd.conf | 2 +- cases/consumption_ownership_test.conf | 2 +- cases/domain_linux_net_inst.conf | 4 +- cases/linux_domain.conf | 10 +- cases/migration/ssh_persistent_paused_no_dst.conf | 24 +- .../migration/ssh_persistent_paused_with_dst.conf | 48 ++-- cases/migration/ssh_persistent_running_no_dst.conf | 24 +- .../migration/ssh_persistent_running_with_dst.conf | 48 ++-- cases/migration/ssh_transient_paused_no_dst.conf | 22 +- cases/migration/ssh_transient_paused_with_dst.conf | 48 ++-- cases/migration/ssh_transient_running_no_dst.conf | 24 +- .../migration/ssh_transient_running_with_dst.conf | 48 ++-- cases/migration/tcp_persistent_paused_no_dst.conf | 24 +- .../migration/tcp_persistent_paused_with_dst.conf | 48 ++-- cases/migration/tcp_persistent_running_no_dst.conf | 24 +- .../migration/tcp_persistent_running_with_dst.conf | 48 ++-- .../tcp_sasl_persistent_paused_no_dst.conf | 8 +- .../tcp_sasl_persistent_paused_with_dst.conf | 16 +- .../tcp_sasl_persistent_running_no_dst.conf | 8 +- .../tcp_sasl_persistent_running_with_dst.conf | 16 +- .../tcp_sasl_transient_paused_no_dst.conf | 8 +- .../tcp_sasl_transient_paused_with_dst.conf | 16 +- .../tcp_sasl_transient_running_no_dst.conf | 8 +- .../tcp_sasl_transient_running_with_dst.conf | 16 +- cases/migration/tcp_transient_paused_no_dst.conf | 22 +- cases/migration/tcp_transient_paused_with_dst.conf | 48 ++-- cases/migration/tcp_transient_running_no_dst.conf | 24 +- .../migration/tcp_transient_running_with_dst.conf | 48 ++-- cases/migration/tls_persistent_paused_no_dst.conf | 24 +- .../migration/tls_persistent_paused_with_dst.conf | 48 ++-- cases/migration/tls_persistent_running_no_dst.conf | 24 +- .../migration/tls_persistent_running_with_dst.conf | 48 ++-- .../tls_sasl_persistent_paused_no_dst.conf | 8 +- .../tls_sasl_persistent_paused_with_dst.conf | 16 +- .../tls_sasl_persistent_running_no_dst.conf | 8 +- .../tls_sasl_persistent_running_with_dst.conf | 16 +- .../tls_sasl_transient_paused_no_dst.conf | 8 +- .../tls_sasl_transient_paused_with_dst.conf | 16 +- .../tls_sasl_transient_running_no_dst.conf | 8 +- .../tls_sasl_transient_running_with_dst.conf | 16 +- cases/migration/tls_transient_paused_no_dst.conf | 22 +- cases/migration/tls_transient_paused_with_dst.conf | 48 ++-- cases/migration/tls_transient_running_no_dst.conf | 24 +- .../migration/tls_transient_running_with_dst.conf | 48 ++-- cases/snapshot.conf | 2 +- cases/windows_domain.conf | 8 +- .../en-US/Understanding_libvirt-test-API.xml | 4 +- .../en-US/Writing_a_test_case.xml | 10 +- env.cfg => global.cfg | 0 libvirt-test-api | 24 +- repos/domain/attach_disk.py | 6 +- repos/domain/attach_interface.py | 4 +- repos/domain/balloon_memory.py | 2 +- repos/domain/create.py | 6 +- repos/domain/define.py | 18 +- repos/domain/detach_disk.py | 6 +- repos/domain/detach_interface.py | 4 +- repos/domain/dump.py | 2 +- repos/domain/install_image.py | 14 +- repos/domain/install_linux_cdrom.py | 28 +- repos/domain/install_linux_check.py | 27 +- repos/domain/install_linux_net.py | 32 +- repos/domain/install_windows_cdrom.py | 22 +- repos/domain/migrate.py | 2 +- repos/domain/update_devflag.py | 8 +- repos/interface/create.py | 2 +- repos/interface/define.py | 4 +- repos/interface/destroy.py | 2 +- repos/interface/undefine.py | 2 +- repos/network/create.py | 4 +- repos/network/define.py | 4 +- repos/npiv/create_virtual_hba.py | 4 +- .../multiple_thread_block_on_domain_create.py | 12 +- repos/snapshot/file_flag.py | 3 +- repos/snapshot/flag_check.py | 3 +- repos/snapshot/internal_create.py | 4 +- repos/storage/activate_pool.py | 2 +- repos/storage/create_dir_pool.py | 4 +- repos/storage/create_dir_volume.py | 4 +- repos/storage/create_fs_pool.py | 8 +- repos/storage/create_iscsi_pool.py | 4 +- repos/storage/create_logical_volume.py | 4 +- repos/storage/create_netfs_pool.py | 8 +- repos/storage/create_netfs_volume.py | 4 +- repos/storage/create_partition_volume.py | 4 +- repos/storage/define_dir_pool.py | 4 +- repos/storage/define_disk_pool.py | 4 +- repos/storage/define_iscsi_pool.py | 4 +- repos/storage/define_logical_pool.py | 4 +- repos/storage/define_mpath_pool.py | 4 +- repos/storage/define_netfs_pool.py | 4 +- repos/storage/define_scsi_pool.py | 4 +- repos/storage/delete_partition_volume.py | 2 +- repos/storage/destroy_pool.py | 2 +- {dist => src/dist}/__init__.py | 0 {dist => src/dist}/redhat/__init__.py | 0 {dist => src/dist}/redhat/env_inspect.py | 5 +- {utils => src}/env_parser.py | 6 +- src/exception.py | 9 +- src/generator.py | 8 +- src/{logxmlparser.py => log_generator.py} | 9 +- src/parser.py | 6 +- src/process.py | 7 +- utils/check.py | 392 -------------------- utils/dev_num.sh | 5 +- utils/disk_num.sh | 5 +- utils/format.py | 6 +- utils/ipget.sh | 2 +- utils/log.py | 6 +- utils/utils.py | 362 ++++++++++++++++++ utils/{xmlbuilder.py => xml_builder.py} | 62 ++-- utils/{xmlgenerator.py => xml_generator.py} | 70 ++-- utils/{XMLParser.py => xml_parser.py} | 13 +- 118 files changed, 1175 insertions(+), 1240 deletions(-) delete mode 100644 NEWS delete mode 100644 TODO rename env.cfg => global.cfg (100%) mode change 100644 => 100755 libvirt-test-api rename {dist => src/dist}/__init__.py (100%) rename {dist => src/dist}/redhat/__init__.py (100%) rename {dist => src/dist}/redhat/env_inspect.py (97%) rename {utils => src}/env_parser.py (96%) rename src/{logxmlparser.py => log_generator.py} (97%) delete mode 100644 utils/check.py rename utils/{xmlbuilder.py => xml_builder.py} (88%) rename utils/{xmlgenerator.py => xml_generator.py} (95%) rename utils/{XMLParser.py => xml_parser.py} (95%) Regards, Osier -- 1.7.7.3 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list