On 01/02/2012 12:39 PM, Peter Krempa wrote: > On 12/07/2011 11:58 AM, Michal Novotny wrote: >> Hi, >> this is the fifth version of my SRV record for DNSMasq patch rebased >> for the current codebase to the bridge driver and libvirt XML file to >> include support for the SRV records in the DNS. The syntax is based on >> DNSMasq man page and tests for both xml2xml and xml2argv were added as >> well. There are some things written a better way in comparison with >> version 4, mainly there's no hack in tests/networkxml2argvtest.c and >> also the xPath context is changed to use a simpler query using the >> virXPathInt() function relative to the current node. >> >> Also, the patch is also fixing the networkxml2argv test to pass both >> checks, i.e. both unit tests and also syntax check. >> >> Please review, >> Michal >> >> Signed-off-by: Michal Novotny<minovotn@xxxxxxxxxx> >> diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h >> index 1be20f8..5ef4878 100644 >> --- a/src/conf/network_conf.h >> +++ b/src/conf/network_conf.h >> @@ -24,6 +24,8 @@ >> #ifndef __NETWORK_CONF_H__ >> # define __NETWORK_CONF_H__ >> >> +#define DNS_RECORD_LENGTH_SRV (512 - 30) /* Limit minus overhead as mentioned in RFC-2782 */ > This line needs to be indented by one space to pass syntax check. Interesting. Even after installing cppi package on my F-16 x86_64 box it didn't fail because of preprocessor indentation test. Thanks for the catch Peter, Michal -- Michal Novotny <minovotn@xxxxxxxxxx>, RHCE, Red Hat Virtualization | libvirt-php bindings | php-virt-control.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list