Re: [PATCH 1/2] command: handle empty buffer argument correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/03/2011 02:18 PM, Stefan Berger wrote:
> On 12/02/2011 01:50 PM, Eric Blake wrote:
>> virBufferContentAndReset (intentionally) returns NULL for a buffer
>> with no content, but it is feasible to invoke a command with an
>> explicit empty string.
>>
>> * src/util/command.c (virCommandAddEnvBuffer): Reject empty string.
>> (virCommandAddArgBuffer): Allow explicit empty argument.
>> * tests/commandtest.c (test9): Test it.
>> * tests/commanddata/test9.log: Adjust.
>> ---
>>   src/util/command.c          |   13 ++++++++++++-
>>   tests/commanddata/test9.log |    4 +++-
>>   tests/commandtest.c         |   13 ++++++++++++-
>>   3 files changed, 27 insertions(+), 3 deletions(-)
> 
> ACK

Thanks; pushed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]