Re: [libvirt-glib 04/37] Add some GVirConfigClock setters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 15, 2011 at 2:37 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> g_return_if_fail(klock != NULL);

I think better is:
g_return_if_fail(GVIR_IS_CONFIG_CLOCK(klock));

> libxml2 provides http://xmlsoft.org/html/libxml-xmlstring.html#BAD_CAST
> which isn't really easy on the eyes. I've got more patches which are not
> ready for review yet, but which move these casts in only a few helper
> functions instead of having them everywhere. If you don't mind, I'll
> address this when all these patches have been sent, is it ok?

sure

-- 
Marc-André Lureau

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]