On Fri, Nov 11, 2011 at 04:20:05PM +0100, Marc-André Lureau wrote:
> Hi
>
> Please merge with previous patch.
>
> > + if (enable)
> > + xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"yes");
> > + else
> > + xmlNewProp(node, (xmlChar*)"enable", (xmlChar*)"no");
> > +}
>
> might be useful to have use a gchar * gvir_config_yes_no (bool condition)
This is factored in a helper function in one of the patches that hasn't
been sent yet.
>
> > + if (strcmp("boot", (char *)node->name) == 0) {
>
> It could use the safer g_strcmp0.
Ah indeed, didn't know about this function, changed.
Christophe
Attachment:
pgpO5TWhRYnOs.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list