于 2011年09月21日 03:23, Eric Blake 写道:
On 09/20/2011 03:09 AM, Osier Yang wrote:Variable "name" is never used in the codes, it's useless. --- tools/virsh.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index e8258c1..371346a 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -10006,13 +10006,12 @@ static bool cmdVolPath(vshControl *ctl, const vshCmd *cmd) { virStorageVolPtr vol; - const char *name = NULL; char * StorageVolPath; if (!vshConnectionUsability(ctl, ctl->conn)) return false; - if (!(vol = vshCommandOptVol(ctl, cmd, "vol", "pool",&name))) { + if (!(vol = vshCommandOptVol(ctl, cmd, "vol", "pool", NULL))) {ACK, and safe to push right now while we still debate about 0.9.6 timing.
Thanks, pushed Osier -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list