Re: [PATCH] virsh: Remove useless codes of cmdVolPath

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/20/2011 03:09 AM, Osier Yang wrote:
Variable "name" is never used in the codes, it's useless.
---
  tools/virsh.c |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index e8258c1..371346a 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -10006,13 +10006,12 @@ static bool
  cmdVolPath(vshControl *ctl, const vshCmd *cmd)
  {
      virStorageVolPtr vol;
-    const char *name = NULL;
      char * StorageVolPath;

      if (!vshConnectionUsability(ctl, ctl->conn))
          return false;

-    if (!(vol = vshCommandOptVol(ctl, cmd, "vol", "pool",&name))) {
+    if (!(vol = vshCommandOptVol(ctl, cmd, "vol", "pool", NULL))) {

ACK, and safe to push right now while we still debate about 0.9.6 timing.

--
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]