Re: [PATCH 5/5] remote generator: Don't rely on $_ being stable over a large function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/5/16 Eric Blake <eblake@xxxxxxxxxx>:
> On 05/15/2011 12:23 AM, Matthias Bolte wrote:
>> Replace $calls{$_} with $call in the dispatch bodies generator function.
>>
>> No functional change included.
>> ---
>> Âdaemon/remote_generator.pl | Â100 ++++++++++++++++++++++---------------------
>> Â1 files changed, 51 insertions(+), 49 deletions(-)
>>
>> diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
>> index c2468b9..5725583 100755
>> --- a/daemon/remote_generator.pl
>> +++ b/daemon/remote_generator.pl
>> @@ -272,11 +272,13 @@ elsif ($opt_b) {
>> Â Â Âmy @keys = sort (keys %calls);
>>
>> Â Â Âforeach (@keys) {
>> + Â Â Â Âmy $call = $calls{$_};
>> +
>> Â Â Â Â Â# skip things which are REMOTE_MESSAGE
>> - Â Â Â Ânext if $calls{$_}->{msg};
>> + Â Â Â Ânext if $call->{msg};
>
> ACK.
>

Thanks, pushed.

Matthias

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]