Re: [PATCH 5/5] remote generator: Don't rely on $_ being stable over a large function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/15/2011 12:23 AM, Matthias Bolte wrote:
> Replace $calls{$_} with $call in the dispatch bodies generator function.
> 
> No functional change included.
> ---
>  daemon/remote_generator.pl |  100 ++++++++++++++++++++++---------------------
>  1 files changed, 51 insertions(+), 49 deletions(-)
> 
> diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
> index c2468b9..5725583 100755
> --- a/daemon/remote_generator.pl
> +++ b/daemon/remote_generator.pl
> @@ -272,11 +272,13 @@ elsif ($opt_b) {
>      my @keys = sort (keys %calls);
>  
>      foreach (@keys) {
> +        my $call = $calls{$_};
> +
>          # skip things which are REMOTE_MESSAGE
> -        next if $calls{$_}->{msg};
> +        next if $call->{msg};

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]