2011/4/14 Eric Blake <eblake@xxxxxxxxxx>: > On 04/13/2011 04:07 PM, Eric Blake wrote: >> Phyp still had several memory leaks and in general some bad >> copy-and-paste design. ÂThis series consolidates some common >> patterns into simpler helpers, avoiding leaks in the process. >> >> Eric Blake (4): >> Â phyp: prefer memcpy over memmove when legal >> Â phyp: avoid memory leaks in return values >> Â phyp: avoid memory leaks in command values >> Â phyp: another simplification >> >> Âsrc/phyp/phyp_driver.c | 1128 +++++++----------------------------------------- >> Â1 files changed, 163 insertions(+), 965 deletions(-) > > Serves me right for thinking Matthias' cleanups had already been > applied. ÂNow I get to rebase, with lots of conflicts :) Sorry for that :( I'm currently quite busy with my studies and can only spent some time on weekends for libvirt development to get some distraction. This results in longer delays between libvirt related things I do. Today, I successfully took an exam and am relaxing with libvirt stuff right now. You probably want to post a rebased v2 before I review your phyp patches, don't you? Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list