More in the ongoing battle to make libvirtd not so leaky. Also related, and still waiting on a review for: virExec (and thus virCommand) have undefined behavior https://www.redhat.com/archives/libvir-list/2010-December/msg00242.html avoid matchpathcon memory leak (although libselinux 2.0.97 finally patched that leak upstream) https://www.redhat.com/archives/libvir-list/2010-December/msg00001.html The leak in qemu_conf covered in patch 3 was introduced with the conversion to virCommand; if you like patch 4, I'd rather combine those into one patch (but patch 3 is a minimal plug). Eric Blake (4): tests: plug memory leaks conf: plug memory leaks qemu: plug memory leak command: ease use with virBuffer src/conf/domain_conf.c | 10 ++++++++++ src/libvirt_private.syms | 2 ++ src/qemu/qemu_conf.c | 42 +++++++++--------------------------------- src/util/command.c | 43 +++++++++++++++++++++++++++++++++++++++++++ src/util/command.h | 17 +++++++++++++++++ tests/qemuxml2argvtest.c | 3 +-- 6 files changed, 82 insertions(+), 35 deletions(-) -- 1.7.3.2 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list