2010/10/28 Daniel P. Berrange <berrange@xxxxxxxxxx>: > On Fri, Oct 22, 2010 at 09:44:22PM +0200, Matthias Bolte wrote: >> This partly reverts df90ca7661b0a789bd790ccf8258a4527c13eb8d. >> >> Don't disable the VirtualBox driver when configure can't find >> VBoxXPCOMC.so, rely on detection at runtime again instead. >> >> Keep --with-vbox=/path/to/virtualbox intact, added to for: >> https://bugzilla.redhat.com/show_bug.cgi?id=609185 >> >> Detection order for VBoxXPCOMC.so: >> >> 1. VBOX_APP_HOME environment variable >> 2. configure provided location >> 3. hardcoded list of known locations >> 4. dynamic linker search path >> >> Also cleanup the glue code and improve error reporting. >> --- >> >> Patch is based on Daniel's suggestion in: >> >> https://www.redhat.com/archives/libvir-list/2010-October/msg00852.html >> >> Âconfigure.ac        |  53 +--------- >> Âpo/POTFILES.in       |  Â1 + >> Âsrc/vbox/vbox_XPCOMCGlue.c | Â232 +++++++++++++++++++++++--------------------- >> Âsrc/vbox/vbox_XPCOMCGlue.h |  14 --- >> Â4 files changed, 130 insertions(+), 170 deletions(-) > > ACK, looks good to me > > Daniel > Thanks, pushed. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list