On Fri, Oct 22, 2010 at 09:44:22PM +0200, Matthias Bolte wrote: > This partly reverts df90ca7661b0a789bd790ccf8258a4527c13eb8d. > > Don't disable the VirtualBox driver when configure can't find > VBoxXPCOMC.so, rely on detection at runtime again instead. > > Keep --with-vbox=/path/to/virtualbox intact, added to for: > https://bugzilla.redhat.com/show_bug.cgi?id=609185 > > Detection order for VBoxXPCOMC.so: > > 1. VBOX_APP_HOME environment variable > 2. configure provided location > 3. hardcoded list of known locations > 4. dynamic linker search path > > Also cleanup the glue code and improve error reporting. > --- > > Patch is based on Daniel's suggestion in: > > https://www.redhat.com/archives/libvir-list/2010-October/msg00852.html > > configure.ac | 53 +--------- > po/POTFILES.in | 1 + > src/vbox/vbox_XPCOMCGlue.c | 232 +++++++++++++++++++++++--------------------- > src/vbox/vbox_XPCOMCGlue.h | 14 --- > 4 files changed, 130 insertions(+), 170 deletions(-) ACK, looks good to me Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list