On Sat, Sep 25, 2010 at 12:04:11AM +0530, Harsh Prateek Bora wrote: > This patch introduces new attribute to filesystem element > to support customizable security_model for mount type. > Valid security_model are: passthrough, mapped and none. > > Usage: > <filesystem type='mount' security_model='passthrough'> > <source dir='/export/to/guest'/> > <target dir='mount_tag'/> > </filesystem> Well, there is a missing documentation part in the patch. In what way does having security_model='passthrough', security_model='mapped' or security_model='none' change the behaviour of the library compared to not having the attribute at all. Any patch which modifies the API (and the XML is part of the API) must have a clearly defined semantic, and that definition (and if possible an example) must be provided in the set of patches for the documentation. We cannot accept a patch whose only semantic is "add a given QEmu command line argument" because it makes impossible to try to support the option on other hypervisor or if QEmu end up changing the command line. What is your patch providing in term of API ? Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list