On 3/17/25 7:29 AM, Jiri Denemark via Devel wrote:
On Mon, Mar 17, 2025 at 11:23:00 +0000, Daniel P. Berrangé via Devel wrote:
From: Daniel P. Berrangé <berrange@xxxxxxxxxx>
If a contributor's email domain has a DMARC policy of 'p=quarantine'
or 'p=reject', mailman will apply DMARC countermeasures on all mails
sent to lists.libvirt.org rewriting the "From" header to remove the
sender's email address. e.g.
From: Your Name via <lists.libvirt.org>
If these countermeasures were not applied, affected mail would either
have gon directly to SPAM, or have been entirely rejected. Mailman3
s/gon/gone/
is unable to be configured to guarantee no mangling of the mail body
so these countermeasures are unavoidable for lists.libvirt.org.
Amongst the various downsides, the From address rewriting has the
bad effect of mangling git commit author attribution.
To avoid this it is required to add two additional git config
settings:
$ git config --global format.from "Your Name <your@xxxxxxxxx>"
$ git config --global format.forceInBodyFrom true
Note, *both* are required, even if your ``format.from`` matches
your existing git identity, because the latter only takes effect
once the former is set.
Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
Thanks a lot.
Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>
Reviewed-by: Laine Stump via Devel <devel@xxxxxxxxxxxxxxxxx>
:-)
A couple thoughts:
1) Some people might rather have the email address (and maybe also
forceInBodyFrom) set for just certain projects rather than globally.
2) Is there a config file that could be part of the project files in the
main directory that could have "format.forceInBodyFrom true" added
(similar to how we have a .gitpublish that's checked out with everything
else)?
3) Maybe this could also/instead be added as a config item to
git-publish and could be added to the libvirt .gitpublish file so that
at least it would be automatic for those of us who religiously use
git-publish. I suppose I should go look at the git-publish source...
