On 3/14/25 12:51, Kirill Shchetiniuk wrote: > During fixing some other issue found out a few minor bugs > related to CH driver. > > First bug is related to monitor object ref count > in virCHStartEventHandler and virCHEventHandlerLoop, as > object was unrefed by parent while is still used by child > thread. Moved object unref to the correct place to the > correct thread. > > Second bug is related to v object ref count in > virCHStartEventHandler, as vm object was unrefed, > while is still used later, move object unref to > after its last usage. > > Third bug is related to error handling and > propagation. Last meaninful error was reset > by virCHProcessStop, which have led to > unknown error message in virsh. Add error > preservation at the begining of the function > and restoring it at the end to keep > consistent error output > > > Kirill Shchetiniuk (2): > ch: virCHProcessStop preserve last meaningful error > ch: ref count fix in virCHEventHandlerLoop and virCHStartEventHandler > > src/ch/ch_events.c | 4 ++-- > src/ch/ch_process.c | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > I've reworded commit messages a bit and merged. Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Congratulations on your first libvirt contribution! Michal
