> > Nonetheless, many of my manual changes highlighted > > existing (bogus) attempts to translate VIR_WARN0? diagnostics. > > Those should be addressed regardless. > > > > Considering the large number of existing VIR_WARN uses with strings > > marked for translation, do you want to reconsider? > > > > $ g grep 'VIR_WARN.*_('|wc -l > > 60 > > > > or would you prefer to remove the _(...) marks on those 60 uses? > > Yes, pretty much all of them can be removed. I notice there are also needless > translations in a handful of files with VIR_DEBUG, and for VIR_ERROR too. IIRC, there was an agreement on the list that VIR_ERROR should be left translated since those messages can make their way to end users. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list