Re: [PATCH v2 3/4] util: Change return type of virSCSIVHostDeviceSetUsedBy to void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 28, 2024 at 16:28:09 +0300, Alexander Kuznetsov wrote:
> This function return value is invariant since 18f3771, so change
> its type and remove all dependent checks.
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.
> 
> Reported-by: Pavel Nekrasov <p.nekrasov@xxxxxxxxxxx>
> Signed-off-by: Alexander Kuznetsov <kuznetsovam@xxxxxxxxxxxx>
> ---
>  src/hypervisor/virhostdev.c | 3 +--
>  src/util/virscsivhost.c     | 6 ++----
>  src/util/virscsivhost.h     | 2 +-
>  3 files changed, 4 insertions(+), 7 deletions(-)
...
> diff --git a/src/util/virscsivhost.h b/src/util/virscsivhost.h
> index a7299382db..caaac26328 100644
> --- a/src/util/virscsivhost.h
> +++ b/src/util/virscsivhost.h
> @@ -50,7 +50,7 @@ void virSCSIVHostDeviceListDel(virSCSIVHostDeviceList *list,
>                                 virSCSIVHostDevice *dev);
>  virSCSIVHostDeviceList *virSCSIVHostDeviceListNew(void);
>  virSCSIVHostDevice *virSCSIVHostDeviceNew(const char *name);
> -int virSCSIVHostDeviceSetUsedBy(virSCSIVHostDevice *dev,
> +void virSCSIVHostDeviceSetUsedBy(virSCSIVHostDevice *dev,
>                                  const char *drvname,
>                                  const char *domname);

Indentation error.

Jirka



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux