On Thu, Nov 28, 2024 at 16:28:08 +0300, Alexander Kuznetsov wrote: > This function return value is invariant since 18f3771, so change > its type and remove all dependent checks. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Reported-by: Pavel Nekrasov <p.nekrasov@xxxxxxxxxxx> > Signed-off-by: Alexander Kuznetsov <kuznetsovam@xxxxxxxxxxxx> > --- > src/hypervisor/virhostdev.c | 12 ++++-------- > src/util/virscsi.c | 4 +--- > src/util/virscsi.h | 2 +- > tests/virscsitest.c | 6 ++---- > 4 files changed, 8 insertions(+), 16 deletions(-) > ... > diff --git a/src/util/virscsi.h b/src/util/virscsi.h > index ec34303bdc..d76ee13bcc 100644 > --- a/src/util/virscsi.h > +++ b/src/util/virscsi.h > @@ -50,7 +50,7 @@ virSCSIDevice *virSCSIDeviceNew(const char *sysfs_prefix, > bool shareable); > > void virSCSIDeviceFree(virSCSIDevice *dev); > -int virSCSIDeviceSetUsedBy(virSCSIDevice *dev, > +void virSCSIDeviceSetUsedBy(virSCSIDevice *dev, > const char *drvname, > const char *domname); Indentation error. > bool virSCSIDeviceIsAvailable(virSCSIDevice *dev); Jirka
