On Thu, Apr 11, 2024 at 19:01:49 -0700, wucf@xxxxxxxxxxxxx wrote: > From: Chun Feng Wu <wucf@xxxxxxxxxxxxx> > > * Define new structs 'virDomainThrottleGroupDef' and 'virDomainThrottleFilterDef' > * Update _virDomainDef to include virDomainThrottleGroupDef > * Update _virDomainDiskDef to include virDomainThrottleFilterDef > * Support new resource operations for DOM XML and structs, corresponding "Parse" and "Format" methods are provided > > Signed-off-by: Chun Feng Wu <wucf@xxxxxxxxxxxxx> > --- [...] > diff --git a/src/conf/virconftypes.h b/src/conf/virconftypes.h > index 0779bc224b..1cf68b2814 100644 > --- a/src/conf/virconftypes.h > +++ b/src/conf/virconftypes.h > @@ -80,6 +80,10 @@ typedef struct _virDomainBlkiotune virDomainBlkiotune; > > typedef struct _virDomainBlockIoTuneInfo virDomainBlockIoTuneInfo; > > +typedef struct _virDomainBlockIoTuneInfo virDomainThrottleGroupDef; > + NACK, don't do this. The name should match. If it is the same, treat it the same as it will allow refactors. _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
