On 4/5/24 23:12, Brett Holman wrote: >> A colleague asked about the status of this patch and it's availability in >> downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina >> has also reviewed the patch. I've added both R-B to the commit and pushed it. > > I appreciate the review and push \o/ > > Should I have resubmitted with the R-B in the commit message after > Kristina's review? Mailing list contribution process is still very > unfamiliar to me. > No need. Unfortunately, things lined up 'badly'. I mean, Kristina gave her reviewed-by during freeze period in which we try to stabilize libvirt and prepare it for upcoming release. Therefore, we do not merge new features, just bug fixes. And since she doesn't have commit access to the repo, she did not merge the patch once after the release. I knew I wanted to do it, but then Easter happened (public holiday) and quite frankly - just forgot, once I was back. Thanks Jim for keeping an eye on this! >> This appears to be your first commit to the libvirt project. Congratulations! :-) Indeed, congratulations! Michal _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
