Re: [PATCH] virsysinfo: Try reading DMI table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/26/24 13:38, brett.holman@xxxxxxxxxxxxx wrote:
From: Brett Holman <brett.holman@xxxxxxxxxxxxx>

Add DMI support for risc-v and mips. Attempt to read dmidecode and
fall back to old behavior if that fails.

The SMBIOS specification[1] officially supports both RISC-V and LoongArch.
Some mips-based Loongson-3 processors also have SMBIOS.

[1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf

Signed-off-by: Brett Holman <brett.holman@xxxxxxxxxxxxx>

Hi Brett,

A colleague asked about the status of this patch and it's availability in downstream openSUSE packages. I took a peek and LGTM. I then noticed Kristina has also reviewed the patch. I've added both R-B to the commit and pushed it.

This appears to be your first commit to the libvirt project. Congratulations! :-)

Regards,
Jim

---
  src/util/virsysinfo.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c
index 4a03fc3246..0d9083c891 100644
--- a/src/util/virsysinfo.c
+++ b/src/util/virsysinfo.c
@@ -1249,6 +1249,8 @@ virSysinfoRead(void)
      (defined(__x86_64__) || \
       defined(__i386__) || \
       defined(__amd64__) || \
+     defined(__riscv__) || \
+     defined(__mips__) || \
       defined(__loongarch__))
      return virSysinfoReadDMI();
  #else /* WIN32 || not supported arch */
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux