On Mon, Apr 01, 2024 at 15:58:30 +0200, Andrea Bolognani wrote: > Right now, we display the message before actually attempting > to connect to the VM console. That operation, however, can > fail for a number of reasons: for example, is the VM doesn't > have a serial device, the output ends up looking like > > $ virsh console cirros > Connected to domain 'cirros' > Escape character is ^] (Ctrl + ]) > error: internal error: cannot find character device <null> > > The initial message is misleading. Change things so that it's > only printed if we actually successfully connected to the VM > console. > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > tools/virsh-console.c | 19 +++++++++++++------ > tools/virsh-domain.c | 7 ------- > 2 files changed, 13 insertions(+), 13 deletions(-) Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx> _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
