Re: [PATCH v2 1/1] remote: properly initialize objects in ACL helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 19, 2024 at 15:07:04 +0100, Denis V. Lunev wrote:
> Commit 2ecdf259299813c2c674377e22a0acbce5ccbbb2 was intended to
> implement two things: reduce stack usage inside ACL helpers and
> minimally initialize virDomainDef object to avoid passing garbage
> inside validation framework. Though original commit has not
> touched other ACL helpers.
> 
> This patch adds proper clauses to
>     remoteRelayNetworkEventCheckACL
>     remoteRelayStoragePoolEventCheckACL
>     remoteRelayNodeDeviceEventCheckACL
>     remoteRelaySecretEventCheckACL
> 
> Signed-off-by: Denis V. Lunev <den@xxxxxxxxxx>
> CC: Peter Krempa <pkrempa@xxxxxxxxxx>
> CC: Roman Grigoriev <rgrigoriev@xxxxxxxxxxxxx>

I'll drop the CC lines if you are okay with that as it doesn't seem to
be needed to record that info in git.

> ---
>  src/remote/remote_daemon_dispatch.c | 32 ++++++++++++++---------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> Changes from v1:
> * g_autoptr is replaced with g_autofree upon reached consensus
> * patch 1 in series has been dropped


Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>

and I'll push it after the release is done later today.
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux