[PATCH v4 18/19] libxl: change type to void libxlMakeDomainDeviceHostdevCaps()

[Dmitry Frolov <frolov@xxxxxxxxx>]

libxlMakeDomainDeviceHostdevCaps() returns nothing except 0. Changing
return type to void.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Frolov <frolov@xxxxxxxxx>
---
 src/libxl/libxl_capabilities.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/libxl/libxl_capabilities.c b/src/libxl/libxl_capabilities.c
index 2b0652b483..159d923fc3 100644
--- a/src/libxl/libxl_capabilities.c
+++ b/src/libxl/libxl_capabilities.c
@@ -585,7 +585,7 @@ libxlMakeDomainDeviceVideoCaps(virDomainCapsDeviceVideo *dev)
     return 0;
 }
 
-static int
+static void
 libxlMakeDomainDeviceHostdevCaps(virDomainCapsDeviceHostdev *dev)
 {
     dev->supported = VIR_TRISTATE_BOOL_YES;
@@ -616,7 +616,6 @@ libxlMakeDomainDeviceHostdevCaps(virDomainCapsDeviceHostdev *dev)
 
     virDomainCapsEnumClear(&dev->pciBackend);
     VIR_DOMAIN_CAPS_ENUM_SET(dev->pciBackend, VIR_DEVICE_HOSTDEV_PCI_DRIVER_NAME_XEN);
-    return 0;
 }
 
 virCaps *
@@ -674,9 +673,8 @@ libxlMakeDomainCapabilities(virDomainCaps *domCaps,
     libxlMakeDomainDeviceGraphicsCaps(graphics);
     libxlMakeDomainDeviceVideoCaps(video);
 
-    if (STRNEQ(domCaps->machine, "xenpvh") &&
-        libxlMakeDomainDeviceHostdevCaps(hostdev) < 0)
-        return -1;
+    if (STRNEQ(domCaps->machine, "xenpvh"))
+        libxlMakeDomainDeviceHostdevCaps(hostdev);
 
     domCaps->features[VIR_DOMAIN_CAPS_FEATURE_IOTHREADS] = VIR_TRISTATE_BOOL_NO;
     domCaps->features[VIR_DOMAIN_CAPS_FEATURE_VMCOREINFO] = VIR_TRISTATE_BOOL_NO;
-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx