[PATCH v4 15/19] libxl: change type to void xenParseXLNamespaceData()

[Dmitry Frolov <frolov@xxxxxxxxx>]

xenParseXLNamespaceData() returns nothing except 0. Changing
return type to void.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Dmitry Frolov <frolov@xxxxxxxxx>
---
 src/libxl/xen_xl.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c
index 553aa77896..ea825e85bd 100644
--- a/src/libxl/xen_xl.c
+++ b/src/libxl/xen_xl.c
@@ -1017,7 +1017,7 @@ xenParseXLChannel(virConf *conf, virDomainDef *def)
     return -1;
 }
 
-static int
+static void
 xenParseXLNamespaceData(virConf *conf, virDomainDef *def)
 {
     virConfValue *list = virConfGetValue(conf, "device_model_args");
@@ -1027,7 +1027,7 @@ xenParseXLNamespaceData(virConf *conf, virDomainDef *def)
     size_t n = 0;
 
     if (!list || list->type != VIR_CONF_LIST)
-        return 0;
+        return;
 
     list = list->list;
 
@@ -1039,7 +1039,7 @@ xenParseXLNamespaceData(virConf *conf, virDomainDef *def)
     }
 
     if (nargs == 0)
-        return 0;
+        return;
 
     nsdata = g_new0(libxlDomainXmlNsDef, 1);
     def->namespaceData = nsdata;
@@ -1052,8 +1052,6 @@ xenParseXLNamespaceData(virConf *conf, virDomainDef *def)
 
         nsdata->args[n++] = g_strdup(next->str);
     }
-
-    return 0;
 }
 
 virDomainDef *
@@ -1104,8 +1102,7 @@ xenParseXL(virConf *conf,
     if (xenParseXLChannel(conf, def) < 0)
         return NULL;
 
-    if (xenParseXLNamespaceData(conf, def) < 0)
-        return NULL;
+    xenParseXLNamespaceData(conf, def);
 
     if (virDomainDefPostParse(def, VIR_DOMAIN_DEF_PARSE_ABI_UPDATE,
                               xmlopt, NULL) < 0)
-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@xxxxxxxxxxxxxxxxx
To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx