On Mon, Jan 08, 2024 at 12:07:16PM +0000, Daniel P. Berrangé wrote: > On Mon, Jan 08, 2024 at 02:57:40AM -0800, Andrea Bolognani wrote: > > On Mon, Jan 08, 2024 at 11:54:00AM +0100, Peter Krempa wrote: > > > On Mon, Jan 08, 2024 at 11:43:24 +0100, Andrea Bolognani wrote: > > > > +++ b/ci/integration.yml > > > > @@ -1,6 +1,10 @@ > > > > include: > > > > - 'ci/integration-template.yml' > > > > > > > > +# XXX The integration tests use artifacts produced by the libvirt-perl > > > > > > XXX? Either use 'Important:' 'Note:' or nothing altogether. > > > > That gets automatically highlighted by vim, which helps make it stand > > out. 'NOTE' gets the same effect though. Would that work for you? > > "NOTE" is more appropriate, because IMHO "XXX" indicates something that > is /already/ broken. That'd be "FIXME" IMO, I see "XXX" as a generic "you attention needed here" marker. But the interpretation is not entirely clear-cut, and I'm perfectly happy with using "NOTE" :) Can I get ACKs for the rest of the series too, please? -- Andrea Bolognani / Red Hat / Virtualization _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
