On Mon, Jan 08, 2024 at 02:57:40AM -0800, Andrea Bolognani wrote: > On Mon, Jan 08, 2024 at 11:54:00AM +0100, Peter Krempa wrote: > > On Mon, Jan 08, 2024 at 11:43:24 +0100, Andrea Bolognani wrote: > > > These are special in that, when a new target is introduced, some > > > preparation is needed before the changes can be merged. Since > > > this only happens every six months or so, it's unsurprising that > > > we keep messing it up and forgetting some steps. Having notes > > > right in the file will hopefully help going forward. > > > > > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > > > --- > > > ci/integration.yml | 20 ++++++++++++++++++++ > > > 1 file changed, 20 insertions(+) > > > > > > diff --git a/ci/integration.yml b/ci/integration.yml > > > index ff1bb5d81d..fec9ef9256 100644 > > > --- a/ci/integration.yml > > > +++ b/ci/integration.yml > > > @@ -1,6 +1,10 @@ > > > include: > > > - 'ci/integration-template.yml' > > > > > > +# XXX The integration tests use artifacts produced by the libvirt-perl > > > > XXX? Either use 'Important:' 'Note:' or nothing altogether. > > That gets automatically highlighted by vim, which helps make it stand > out. 'NOTE' gets the same effect though. Would that work for you? "NOTE" is more appropriate, because IMHO "XXX" indicates something that is /already/ broken. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Devel mailing list -- devel@xxxxxxxxxxxxxxxxx To unsubscribe send an email to devel-leave@xxxxxxxxxxxxxxxxx
