Re: [libvirt PATCH 12/12] ci: jobs.sh: Define and create SCRATCH_DIR for local executions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 18, 2023 at 12:22:48PM +0200, Erik Skultety wrote:
> Running outside of GitLab will likely not have the variable set and
> hence the execution would fail. To make sure we always start with a
> clean scratch dir (which may or may not be the best thing), create it
> with 'mktemp'. The main reason for a temporary directory is to ensure a
> clean environment for the job every time run_integration function is
> run. For repeated interactive use case, it is imperative that the
> developer takes care of their environment.
> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  ci/jobs.sh | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux