[libvirt PATCH 01/12] syntax-check: Drop the shell's 'check for minus' rule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Apparently we've only had it because the -[ao] options weren't portable
at the time, but according to
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html

both are defined in POSIX.1-2017 revision which is old enough for all
our supported platforms to have adopted it already. Therefore, drop the
rule.

Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
---
 build-aux/syntax-check.mk | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index d7cf109fbd..5718768193 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -1201,15 +1201,6 @@ sc_prohibit_double_semicolon:
 	halt="Double semicolon detected" \
 	  $(_sc_search_regexp)
 
-_ptm1 = use "test C1 && test C2", not "test C1 -''a C2"
-_ptm2 = use "test C1 || test C2", not "test C1 -''o C2"
-# Using test's -a and -o operators is not portable.
-# We prefer test over [, since the latter is spelled [[ in configure.ac.
-sc_prohibit_test_minus_ao:
-	@prohibit='(\<test| \[+) .+ -[ao] ' \
-	halt='$(_ptm1); $(_ptm2)' \
-	  $(_sc_search_regexp)
-
 # Avoid a test bashism.
 sc_prohibit_test_double_equal:
 	@prohibit='(\<test| \[+) .+ == ' \
-- 
2.41.0




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux