On 9/5/23 2:55 AM, Peter Krempa wrote:
On Thu, Aug 31, 2023 at 16:40:06 -0500, Jonathon Jongsma wrote:
Change the return value for qemuNbdkitProcessRestart() and
qemuNbdkitStorageSourceManageProcess() to return an error status. The
main effect of this change is that when libvirt starts up and reconnects
to an already-running domain with an nbdkit-backed disk, it will return
an error if it fails to restart any nbdkit processes that are not found
to be running or if it fails to monitor any running nbdkit processes.
These failures will result in the domain being killed.
I don't quite understand why this is a separate patch, but ...
Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx>
---
src/qemu/qemu_driver.c | 3 ++-
src/qemu/qemu_nbdkit.c | 34 ++++++++++++++++------------------
src/qemu/qemu_nbdkit.h | 4 ++--
src/qemu/qemu_process.c | 6 ++++--
4 files changed, 24 insertions(+), 23 deletions(-)
Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>
Yes, I probably should have explained why it was separate. I initially
made it separate in case you felt that the behavior change was not
acceptable and wanted me to drop it. I will squash it into the previous
patch.
Jonathon
